haskell.packages.native-bignum: exclude recurseForDerivations#440347
haskell.packages.native-bignum: exclude recurseForDerivations#440347wolfgangwalther merged 2 commits intoNixOS:masterfrom
Conversation
This was accidentally introduced when it was added to `haskell.compiler`. This code is a bit odd, because it iterates through the compiler attributes and then tries to access the same name in packages, which fails in this case. Seems like this was just a copy-paste error, this should iterate through packages instead.
These versions were dropped from Nixpkgs already.
4e4765a to
2f336e2
Compare
trofi
left a comment
There was a problem hiding this comment.
Fixes the eval for me. Thank you!
|
Why does a modification to release-haskell.nix need a merge to master and a backport? Don’t we just use that file on the haskell-updates branch? |
|
I backported these changes not because of |
| "ghc88" | ||
| "ghc884" |
There was a problem hiding this comment.
Just double checked, ghc884 was removed in #268509. That's certainly no problem to backport this cleanup along to release-25.05.
|
Successfully created backport PR for |
This was accidentally introduced when it was added to
haskell.compiler. This code is a bit odd, because it iterates through the compiler attributes and then tries to access the same name in packages, which fails in this case.I opted not to clean this up by changing to iterate through the packages instead, because this would need formatting changes for the whole block of package set definitions and would cause conflicts with a few PRs removing older GHC versions. We can do that later.Seems like this was just a copy-paste error, this should iterate through packages instead.Fixes #437195 (comment)
cc @trofi
Things done
Add a 👍 reaction to pull requests you find important.