Skip to content

haskell.packages.native-bignum: exclude recurseForDerivations#440347

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther:haskell-packages-recurse
Sep 5, 2025
Merged

haskell.packages.native-bignum: exclude recurseForDerivations#440347
wolfgangwalther merged 2 commits intoNixOS:masterfrom
wolfgangwalther:haskell-packages-recurse

Conversation

@wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Sep 5, 2025

This was accidentally introduced when it was added to haskell.compiler. This code is a bit odd, because it iterates through the compiler attributes and then tries to access the same name in packages, which fails in this case.

I opted not to clean this up by changing to iterate through the packages instead, because this would need formatting changes for the whole block of package set definitions and would cause conflicts with a few PRs removing older GHC versions. We can do that later. Seems like this was just a copy-paste error, this should iterate through packages instead.

Fixes #437195 (comment)

cc @trofi

Things done


Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Sep 5, 2025
This was accidentally introduced when it was added to
`haskell.compiler`. This code is a bit odd, because it iterates through
the compiler attributes and then tries to access the same name in
packages, which fails in this case.

Seems like this was just a copy-paste error, this should iterate through
packages instead.
These versions were dropped from Nixpkgs already.
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the eval for me. Thank you!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 5, 2025
@maralorn
Copy link
Member

maralorn commented Sep 5, 2025

Why does a modification to release-haskell.nix need a merge to master and a backport? Don’t we just use that file on the haskell-updates branch?

@wolfgangwalther
Copy link
Contributor Author

I backported these changes not because of release-haskell.nix, but because of packages-config.nix, where I had quite a few changes lately. These PRs also involved changes to release.nix and/or release-outpaths.nix (now ci/eval/outpaths.nix). And since we're backporting all changes to CI, one thing lead to another. TLDR: This is just part of a wider effort in that area to avoid dealing with merge conflicts when I work on the related files.

Comment on lines -13 to -14
"ghc88"
"ghc884"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checked, ghc884 was removed in #268509. That's certainly no problem to backport this cleanup along to release-25.05.

@wolfgangwalther wolfgangwalther merged commit f7eabda into NixOS:master Sep 5, 2025
31 of 34 checks passed
@wolfgangwalther wolfgangwalther deleted the haskell-packages-recurse branch September 5, 2025 10:17
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Sep 5, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants